Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feed): Add loader when Gno react #1393

Merged
merged 10 commits into from
Nov 23, 2024
Merged

fix(feed): Add loader when Gno react #1393

merged 10 commits into from
Nov 23, 2024

Conversation

WaDadidou
Copy link
Collaborator

@WaDadidou WaDadidou commented Nov 18, 2024 •
edited
Loading

Add a loader when react on Gno

Closes #1392

@WaDadidou WaDadidou added bug Something isn't working Social Feed Everything related to the Social Feed labels Nov 18, 2024
@WaDadidou WaDadidou self-assigned this Nov 18, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 18, 2024 •
edited
Loading

✅ Deploy Preview for testitori ready!

Name Link
🔨 Latest commit 269f23f
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/673f6337d57dbf000895d5f8
😎 Deploy Preview https://deploy-preview-1393--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 18, 2024 •
edited
Loading

✅ Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 269f23f
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/673f6337084dbf00089f846a
😎 Deploy Preview https://deploy-preview-1393--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WaDadidou WaDadidou changed the title fix(feed): Add loader when Gno react, add toasts error fix(feed): Add loader when Gno react, add toasts error, rename hook and fucntions Nov 18, 2024
@WaDadidou WaDadidou changed the title fix(feed): Add loader when Gno react, add toasts error, rename hook and fucntions fix(feed): Add loader when Gno react, add toasts error, rename hook and functions Nov 18, 2024
MikaelVallenet
MikaelVallenet previously approved these changes Nov 20, 2024
View reviewed changes
n0izn0iz
n0izn0iz requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react fails on this PR with
Screenshot 2024-11-20 at 11 09 19

@WaDadidou
chore(feed): remove out of scope code,
0db0ab2 
FIX BIG MISTAKE in postMutate identifier
@WaDadidou WaDadidou changed the title fix(feed): Add loader when Gno react, add toasts error, rename hook and functions fix(feed): Add loader when Gno react Nov 20, 2024
@n0izn0iz n0izn0iz enabled auto-merge November 23, 2024 03:04
n0izn0iz
n0izn0iz approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hthieu1110
hthieu1110 approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@hthieu1110 hthieu1110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n0izn0iz n0izn0iz added this pull request to the merge queue Nov 23, 2024
Merged via the queue into main with commit 13cf4eb Nov 23, 2024
23 checks passed
@n0izn0iz n0izn0iz deleted the fix-react-gno-feedbacks branch November 23, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n0izn0iz n0izn0iz n0izn0iz approved these changes

@hthieu1110 hthieu1110 hthieu1110 approved these changes

@omarsy omarsy Awaiting requested review from omarsy

@Villaquiranm Villaquiranm Awaiting requested review from Villaquiranm

@MikaelVallenet MikaelVallenet Awaiting requested review from MikaelVallenet

Assignees

@WaDadidou WaDadidou

Labels
bug Something isn't working Social Feed Everything related to the Social Feed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(feed): No loader when react to Gno post
4 participants
@WaDadidou @hthieu1110 @n0izn0iz @MikaelVallenet