feat(multisig): Add feedbacks to creation form #1354

WaDadidou · 2024-11-15T01:33:48Z

This PR add error feedbacks to the Multisig creation form. I added 2 try catch
It also add a loader to the PrimaryButton.

Existing errors

New errors

- Add invalidation cases - Fix errors displaying for addresses - Add loader for await getCosmosAccount usage - Properly disable PrimaryButton

netlify · 2024-11-15T01:34:03Z

✅ Deploy Preview for testitori ready!

Name	Link
🔨 Latest commit	`e30148a`
🔍 Latest deploy log	https://app.netlify.com/sites/testitori/deploys/673e333b8d677600097b22f2
😎 Deploy Preview	https://deploy-preview-1354--testitori.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-11-15T01:34:06Z

✅ Deploy Preview for teritori-dapp ready!

Name	Link
🔨 Latest commit	`e30148a`
🔍 Latest deploy log	https://app.netlify.com/sites/teritori-dapp/deploys/673e333b38beae0008fe5273
😎 Deploy Preview	https://deploy-preview-1354--teritori-dapp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hthieu1110

Overall LGTM

n0izn0iz

This introduces a bug when you don't change the Address #1 that is automatically injected, my guess it does not fetch the public key of this address

(does not happen on master)

WaDadidou · 2024-11-15T15:03:11Z

An issue:
When the form is valid, the PrimaryButton is still disabled, so the user has to manually modify an input to enable the button

Update: Fixed => 40f3c36

WaDadidou · 2024-11-15T20:40:37Z

This introduces a bug when you don't change the Address #1 that is automatically injected, my guess it does not fetch the public key of this address
(does not happen on master)

Fixed => 40f3c36

packages/screens/Multisig/MultisigCreateScreen.tsx

packages/utils/errors.ts

n0izn0iz

it's very weird that we have a different behavior before and after the first submit attempt IMO

…reateScreen, add loader

n0izn0iz · 2024-11-18T23:47:36Z

packages/screens/Multisig/MultisigCreateScreen.tsx

+      setToast({
+        type: "error",
+        mode: "normal",
+        title: "Failed to create multisig",
+        message,
+      });


why do you add this? there is already a wrapWithFeedback around the submit call

I forgot wrapWithFeedback.
7666d91

packages/screens/Multisig/MultisigCreateScreen.tsx

n0izn0iz · 2024-11-19T20:34:24Z

packages/screens/Multisig/MultisigCreateScreen.tsx

  };

-  const onAddressChange = async (index: number, value: string) => {
+  const onValidate = async (index: number, value: string) => {


Suggested change

const onValidate = async (index: number, value: string) => {

const handleAddressChange = async (index: number, value: string) => {

nit: it doesn't do only validation but also get the pubkey, name could be misleading

n0izn0iz

LGTM

hthieu1110

LGTM

fix(multisig): Enhance creation form

9b1cb31

- Add invalidation cases - Fix errors displaying for addresses - Add loader for await getCosmosAccount usage - Properly disable PrimaryButton

hthieu1110 reviewed Nov 15, 2024

View reviewed changes

n0izn0iz requested changes Nov 15, 2024

View reviewed changes

n0izn0iz changed the title ~~Fix(multisig): Enhance the creation form~~ feat(multisig): enhance the creation form Nov 15, 2024

fix(multisig): Prevent broken controls by making some controls onSubmit

40f3c36

feat(multisig): Add address network control

83a5a64

WaDadidou requested review from hthieu1110 and n0izn0iz November 15, 2024 20:57

WaDadidou self-assigned this Nov 15, 2024

WaDadidou requested review from omarsy, Villaquiranm and MikaelVallenet November 15, 2024 20:57

n0izn0iz requested changes Nov 16, 2024

View reviewed changes

packages/screens/Multisig/MultisigCreateScreen.tsx Outdated Show resolved Hide resolved

chore(feed): rename zod object

4c42c7d

WaDadidou commented Nov 16, 2024

View reviewed changes

packages/utils/errors.ts Outdated Show resolved Hide resolved

n0izn0iz requested changes Nov 16, 2024

View reviewed changes

WaDadidou added 2 commits November 18, 2024 17:39

fix(multisig): Rollback: Just add controls to the form from MultisigC…

dea2831

…reateScreen, add loader

fix(multisig): Add missing throw

eb08b74

WaDadidou requested a review from n0izn0iz November 18, 2024 22:52

chore(multisig): remove unused code

7a2dc38

WaDadidou changed the title ~~feat(multisig): enhance the creation form~~ feat(multisig): Add feedbacks to creation form Nov 18, 2024

n0izn0iz reviewed Nov 18, 2024

View reviewed changes

hthieu1110 reviewed Nov 19, 2024

View reviewed changes

packages/screens/Multisig/MultisigCreateScreen.tsx Outdated Show resolved Hide resolved

chore(multisig): Simplify error

7666d91

WaDadidou requested review from n0izn0iz and hthieu1110 November 19, 2024 19:47

n0izn0iz requested changes Nov 19, 2024

View reviewed changes

chore(multisig): rename function

e30148a

n0izn0iz approved these changes Nov 21, 2024

View reviewed changes

n0izn0iz enabled auto-merge November 21, 2024 06:58

hthieu1110 approved these changes Nov 21, 2024

View reviewed changes

n0izn0iz added this pull request to the merge queue Nov 21, 2024

Merged via the queue into main with commit b9fd4e9 Nov 21, 2024
23 checks passed

n0izn0iz deleted the fix-multisig-form branch November 21, 2024 08:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(multisig): Add feedbacks to creation form #1354

feat(multisig): Add feedbacks to creation form #1354

WaDadidou commented Nov 15, 2024 •

edited

Loading

netlify bot commented Nov 15, 2024 •

edited

Loading

netlify bot commented Nov 15, 2024 •

edited

Loading

hthieu1110 left a comment

n0izn0iz left a comment •

edited

Loading

WaDadidou commented Nov 15, 2024 •

edited

Loading

WaDadidou commented Nov 15, 2024 •

edited

Loading

n0izn0iz left a comment

n0izn0iz Nov 18, 2024

WaDadidou Nov 19, 2024

n0izn0iz Nov 19, 2024

WaDadidou Nov 20, 2024

n0izn0iz left a comment

hthieu1110 left a comment

	const onValidate = async (index: number, value: string) => {
	const handleAddressChange = async (index: number, value: string) => {

feat(multisig): Add feedbacks to creation form #1354

feat(multisig): Add feedbacks to creation form #1354

Conversation

WaDadidou commented Nov 15, 2024 • edited Loading

Existing errors

New errors

netlify bot commented Nov 15, 2024 • edited Loading

✅ Deploy Preview for testitori ready!

netlify bot commented Nov 15, 2024 • edited Loading

✅ Deploy Preview for teritori-dapp ready!

hthieu1110 left a comment

Choose a reason for hiding this comment

n0izn0iz left a comment • edited Loading

Choose a reason for hiding this comment

WaDadidou commented Nov 15, 2024 • edited Loading

WaDadidou commented Nov 15, 2024 • edited Loading

n0izn0iz left a comment

Choose a reason for hiding this comment

n0izn0iz Nov 18, 2024

Choose a reason for hiding this comment

WaDadidou Nov 19, 2024

Choose a reason for hiding this comment

n0izn0iz Nov 19, 2024

Choose a reason for hiding this comment

WaDadidou Nov 20, 2024

Choose a reason for hiding this comment

n0izn0iz left a comment

Choose a reason for hiding this comment

hthieu1110 left a comment

Choose a reason for hiding this comment

WaDadidou commented Nov 15, 2024 •

edited

Loading

netlify bot commented Nov 15, 2024 •

edited

Loading

netlify bot commented Nov 15, 2024 •

edited

Loading

n0izn0iz left a comment •

edited

Loading

WaDadidou commented Nov 15, 2024 •

edited

Loading

WaDadidou commented Nov 15, 2024 •

edited

Loading