Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launchpad): add pluralize lib #1334

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

WaDadidou
Copy link
Collaborator

@WaDadidou WaDadidou commented Nov 3, 2024

Add the lib pluralize and @types/pluralize to handle plural strings.
And remove pluralOrNot function

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 04aa397
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/672a6d2fa6e4930008e1d966
😎 Deploy Preview https://deploy-preview-1334--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for testitori ready!

Name Link
🔨 Latest commit 04aa397
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/672a6d2f5f37540008796381
😎 Deploy Preview https://deploy-preview-1334--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WaDadidou WaDadidou self-assigned this Nov 3, 2024
@WaDadidou WaDadidou changed the title Feat: Enhance pluralOrNot function feat(launchpad): enhance plural or not function Nov 3, 2024
@WaDadidou WaDadidou changed the title feat(launchpad): enhance plural or not function feat(launchpad): enhance pluralornot function Nov 3, 2024
@WaDadidou WaDadidou changed the title feat(launchpad): enhance pluralornot function feat(launchpad): enhance pluralOrNot function Nov 4, 2024
packages/utils/text.tsx Outdated Show resolved Hide resolved
hthieu1110
hthieu1110 previously approved these changes Nov 5, 2024
Copy link
Collaborator

@hthieu1110 hthieu1110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MikaelVallenet
MikaelVallenet previously approved these changes Nov 5, 2024
@WaDadidou WaDadidou dismissed stale reviews from MikaelVallenet and hthieu1110 via 686640d November 5, 2024 16:45
@WaDadidou WaDadidou changed the title feat(launchpad): enhance pluralOrNot function feat(launchpad): add pluralize lib Nov 5, 2024
Copy link
Collaborator

@Villaquiranm Villaquiranm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@n0izn0iz n0izn0iz added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 14ff1ee Nov 5, 2024
21 of 22 checks passed
@n0izn0iz n0izn0iz deleted the feat-enhance-plural-or-not branch November 5, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants