feat: mark gifs as PostCategory.Picture #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WaDadidou
requested review from
omniwired,
hthieu1110,
n0izn0iz,
omarsy,
Villaquiranm,
zxxma and
MikaelVallenet
and removed request for
sakul-budhathoki
|
I think GIF is more a VideoNote ^^ it's low fps but still a video |
MikaelVallenet
previously approved these changes
Sep 17, 2024
n0izn0iz
changed the title
Villaquiranm
previously approved these changes
Sep 17, 2024
omarsy
reviewed
Sep 17, 2024
Would you see a GIF displayed in a player like this ? Also, a GIF could be only one frame. Also, users can add many GIFs and many images in one post. I display |
WaDadidou
dismissed stale reviews from Villaquiranm and MikaelVallenet
via
2a1636e
WaDadidou
force-pushed
the
social-gifs-as-picture-post
branch
from
2a1636e to
168509b
Compare
WaDadidou
force-pushed
the
social-gifs-as-picture-post
branch
from
6e64010 to
2fa70e5
Compare
|
maybe we should differentiate betweeen short video that autoplays and long videos that need a click instead but it's out of scope |
n0izn0iz
changed the title
WaDadidou
force-pushed
the
social-gifs-as-picture-post
branch
from
de059a0 to
2fa70e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posts with GIFs get now the
PostCategoryPicture, and are visible in Pics FeedUsers can make posts with only GIFs and no text, as with images files. So, it makes sense to treat these two case as same
PostCategoryAlso, I need that for the Map Feed, to correctly display the GIFs as
Pictureposts on the map.If not, the posts with GIFs will appear as
Normalposts with empty content (Because the text is not mandatory)