feat(Wallet): check mnemonic via bip39.validateMnemonic #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
omniwired
commented
Feb 27, 2024
omniwired
force-pushed
the
feat/wallet-improved-validation
branch
from
05d95d5 to
af4c228
Compare
…llet-improved-validation # Conflicts: # packages/screens/Wallet/Screens/ImportWallet.tsx
omniwired
force-pushed
the
feat/wallet-improved-validation
branch
from
af4c228 to
ab35067
Compare
omniwired
requested review from
sakul-budhathoki and
sachin-into
and removed request for
hthieu1110
sakul-budhathoki
previously approved these changes
Feb 28, 2024
|
mini toasts are merged |
…llet-improved-validation
- Set toast message and duration for invalid mnemonic phrase - Display error toast when mnemonic phrase is invalid
|
@n0izn0iz updated. |
clegirar
pushed a commit
that referenced
this pull request
Mar 20, 2024
* feat(Wallet): check mnemonic via bip39.validateMnemonic * feat(Wallet): improved import * feat(wallet): Improve validation for import wallet screen - Set toast message and duration for invalid mnemonic phrase - Display error toast when mnemonic phrase is invalid --------- Co-authored-by: n0izn0iz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.