Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICA controller #57

Merged
merged 8 commits into from
Dec 2, 2022
Merged

ICA controller #57

merged 8 commits into from
Dec 2, 2022

Conversation

go7066
Copy link
Contributor

@go7066 go7066 commented Nov 18, 2022

No description provided.

@go7066 go7066 marked this pull request as draft November 18, 2022 15:37
@faddat
Copy link

faddat commented Nov 19, 2022

this PR is dangerous because it doesn't also upgrade ibc-go:

https://github.com/cosmos/ibc-go/releases/tag/v3.4.0

Is the current "best" / minimum version, have a look at go.mod in #60

@go7066
Copy link
Contributor Author

go7066 commented Nov 22, 2022

this PR is dangerous because it doesn't also upgrade ibc-go:

https://github.com/cosmos/ibc-go/releases/tag/v3.4.0

Is the current "best" / minimum version, have a look at go.mod in #60

Thanks for the version check, versions are upgraded now.

@go7066 go7066 marked this pull request as ready for review November 30, 2022 17:03
@go7066 go7066 merged commit 09c8603 into main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants