refactor!: restrict addon name to valid programming variable name #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halajohn
changed the title
Previously, any non-empty string could be used as the addon name. To enable the non injection-based addon registration mechanism in the future, the addon name is now restricted to a valid programming variable name. The regular expression is `^[A-Za-z_][A-Za-z0-9_]*$`. BREAKING CHANGE: The addon name must comply with the regular expression mentioned above.
halajohn
force-pushed
the
refactor-restrict-addon-name
branch
from
ef54e7b to
ae4d815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor!: restrict addon name to valid programming variable name
Previously, any non-empty string could be used as the addon name. To enable the non injection-based
addon registration mechanism in the future, the addon name is now restricted to a valid programming
variable name.
The regular expression is
^[A-Za-z_][A-Za-z0-9_]*$.BREAKING CHANGE: The addon name must comply with the regular expression mentioned above.