Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better module registry #460

Merged
merged 5 commits into from
Dec 9, 2024
Merged

feat: better module registry #460

merged 5 commits into from
Dec 9, 2024

Conversation

plutoless
Copy link
Contributor

@plutoless plutoless commented Dec 4, 2024

Purpose

To further enhance module management, solves following issue:

  • all addons should have a label for easy readiness
  • different llm/v2v extension support different tool set
  • only registered modules should i appear, and its type should follow registry configs instead of addon name

Tasks

  • create a module registry class for module management
  • update cfg component to respect registry
  • only compatible tools should be allowed to choose for different llm/v2v models

@plutoless plutoless requested a review from shczhen December 4, 2024 18:33
Copy link
Collaborator

@shczhen shczhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

    export type ModuleType = "stt" | "llm" | "v2v" | "tts";
    export type ToolModuleType = "tool";

May consider enum to limit variable range.

@plutoless plutoless merged commit 3eb90b5 into main Dec 9, 2024
6 checks passed
@plutoless plutoless deleted the feat/module-configs branch December 9, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants