Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output @class for an <ab> that has a @type #724

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

sydb
Copy link
Member

@sydb sydb commented Dec 29, 2024

Addressing issue #723.

Added a small conditional block to the template that matches the <ab> element that converts @type and @subtype to @class, if they are present. This is not, IMHO, the right way to do this, but it better matches the rest of the Stylesheets.

I have not created new tests to specifically exercise this code. That said, it passes all of the current Test2/ and that portion of Test/ that properly runs on my system.

Added a small conditional block to the template that matches
the ab element that converts type= and subtype= to class=,
if they are present. This is not, IMHO, the rigth way to do
this, but it better matches the rest of the Stylesheets.
Copy link
Contributor

@sabineseifert sabineseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

html/html_core.xsl Outdated Show resolved Hide resolved
@trishaoconnor trishaoconnor merged commit ae41e98 into dev Jan 28, 2025
4 checks passed
@trishaoconnor trishaoconnor deleted the sydb_723_type_of_ab_to_class branch January 28, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants