Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#13103]Account request form: No need to CC the email 'Acknowledgement of Instructor Account Request' #13116

Merged
merged 3 commits into from
Jun 12, 2024
Merged

[#13103]Account request form: No need to CC the email 'Acknowledgement of Instructor Account Request' #13116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e02d6d0
#13103:remove admin CC from ACK email
Ashwinn11 May 20, 2024
36e5310
Merge branch 'master' into fix-13103
dishenggg Jun 12, 2024
eaec4d8
Merge branch 'master' into fix-13103
wkurniawan07 Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/java/teammates/sqllogic/api/SqlEmailGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,7 +1021,6 @@ public EmailWrapper generateNewAccountRequestAcknowledgementEmail(AccountRequest
EmailTemplates.INSTRUCTOR_NEW_ACCOUNT_REQUEST_ACKNOWLEDGEMENT, templateKeyValuePairs);
EmailWrapper email = getEmptyEmailAddressedToEmail(emailAddress);
email.setType(EmailType.NEW_ACCOUNT_REQUEST_ACKNOWLEDGEMENT);
email.setBcc(Config.SUPPORT_EMAIL);
email.setSubjectFromType();
email.setContent(content);
return email;
Expand Down
2 changes: 0 additions & 2 deletions src/test/java/teammates/sqllogic/api/SqlEmailGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ void testGenerateNewAccountRequestAcknowledgementEmail_withComments_generatesSuc
EmailWrapper email = sqlEmailGenerator.generateNewAccountRequestAcknowledgementEmail(accountRequest);
verifyEmail(email, "[email protected]", EmailType.NEW_ACCOUNT_REQUEST_ACKNOWLEDGEMENT,
"TEAMMATES: Acknowledgement of Instructor Account Request",
Config.SUPPORT_EMAIL,
"/instructorNewAccountRequestAcknowledgementEmailWithComments.html");
}

Expand All @@ -58,7 +57,6 @@ void testGenerateNewAccountRequestAcknowledgementEmail_withNoComments_generatesS
EmailWrapper email = sqlEmailGenerator.generateNewAccountRequestAcknowledgementEmail(accountRequest);
verifyEmail(email, "[email protected]", EmailType.NEW_ACCOUNT_REQUEST_ACKNOWLEDGEMENT,
"TEAMMATES: Acknowledgement of Instructor Account Request",
Config.SUPPORT_EMAIL,
"/instructorNewAccountRequestAcknowledgementEmailWithNoComments.html");
}

Expand Down
Loading