[#12048] Fix getSessionResultAction bugs #13023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n course migration (TEAMMATES#12959) * Add fields * Change based on feedback * Add changes
* Add patch data migration script for usage stats * Fix hibernate batch query * Revert log
…s for non course migration (TEAMMATES#12959)" This reverts commit 6df39c1.
This reverts commit 0509982.
…MATES#12966)" This reverts commit 611b2cc.
)" This reverts commit 239ae85.
This reverts commit 1292dbe.
cedricongjh
added
s.FinalReview
xenosf
pushed a commit
to xenosf/teammates
that referenced
this pull request
Apr 17, 2024
* [TEAMMATES#12048] Config prod settings and convenience scripts for non course migration (TEAMMATES#12959) * Add fields * Change based on feedback * Add changes * Add reverse data migration script for account (TEAMMATES#12962) * Add changes (TEAMMATES#12965) * V9 non course migration fix to check extra SQL accounts (TEAMMATES#12966) * Add changes * Add isMarked script * Add patch data migration script for usage stats (TEAMMATES#12970) * Add patch data migration script for usage stats * Fix hibernate batch query * Revert log * Initial commit * Revert "[TEAMMATES#12048] Config prod settings and convenience scripts for non course migration (TEAMMATES#12959)" This reverts commit 6df39c1. * Revert "Add reverse data migration script for account (TEAMMATES#12962)" This reverts commit 0509982. * Revert "V9 non course migration fix to check extra SQL accounts (TEAMMATES#12966)" This reverts commit 611b2cc. * Revert "Add patch data migration script for usage stats (TEAMMATES#12970)" This reverts commit 239ae85. * Revert "Add changes (TEAMMATES#12965)" This reverts commit 1292dbe. * Fix lint * Retry lint --------- Co-authored-by: FergusMok <[email protected]> Co-authored-by: Zhang Ziqing <[email protected]> Co-authored-by: Wei Qing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Fix bug in GetSessionResultsAction where QuestionId is not used
Fix code in INSTRUCTOR_RESULT case of GetSessionResultAction