[#12048] SeedDb code for student entities #12990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasCwy
added
s.ToReview
NicolasCwy
approved these changes
Apr 6, 2024
There was a problem hiding this comment.
LGTM, after #12986 is merged update this branch and use any shared constants before we merge it
mingyuanc
requested changes
Apr 6, 2024
| rand.nextInt(3) > 1 ? null : getRandomInstant(), // set deletedAt randomly at 25% chance | ||
| false); | ||
| ofy().save().entities(course).now(); | ||
| } catch (Exception e) { | ||
| log(e.toString()); | ||
| } | ||
|
|
||
| seedStudents(i, courseId); |
There was a problem hiding this comment.
Should seedStudents be in the try block? such that if there is an exception then seedStudents will not run
There was a problem hiding this comment.
Makes sense, could abstract course creation to a function and put both of the methods in the try block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution