Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12946] Revert attributes removed in initialisation of MCS entities #12983

Conversation

domlimm
Copy link
Contributor

@domlimm domlimm commented Apr 5, 2024

Part of #12946.

Outline of Solution
As per title.

For reference: #12948.

@domlimm domlimm added the s.ToReview The PR is waiting for review(s) label Apr 5, 2024
@domlimm domlimm requested review from weiquu and kevin9foong April 5, 2024 12:57
Copy link

github-actions bot commented Apr 5, 2024

Hi @domlimm, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@domlimm domlimm changed the title Revert attributes removed in initialisation of MCS entities [#12946] Revert attributes removed in initialisation of MCS entities Apr 5, 2024
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint issues are caused by the spotBugs checks, so we need to suppress the FindBugs warnings. See comments below, still need to add import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; right above import jakarta.persistence.CascadeType;

Otherwise looks fine

@domlimm domlimm force-pushed the mcs/revert-attributes-removal branch 2 times, most recently from 538f27d to d7a9c54 Compare April 15, 2024 12:27
@domlimm domlimm force-pushed the mcs/revert-attributes-removal branch from 538f27d to 3db7cfc Compare April 15, 2024 12:57
@domlimm
Copy link
Contributor Author

domlimm commented Apr 15, 2024

@weiquu Thanks wq! Have made the changes. Will request for review once checks are completed.

@domlimm domlimm requested a review from weiquu April 15, 2024 13:25
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's fix the other tests only after the current round of E2E tests migration is done

@weiquu weiquu merged commit 871f822 into TEAMMATES:multiple-course-structures Apr 15, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToReview The PR is waiting for review(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants