-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12946] Revert attributes removed in initialisation of MCS entities #12983
[#12946] Revert attributes removed in initialisation of MCS entities #12983
Conversation
Hi @domlimm, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lint issues are caused by the spotBugs
checks, so we need to suppress the FindBugs
warnings. See comments below, still need to add import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
right above import jakarta.persistence.CascadeType;
Otherwise looks fine
538f27d
to
d7a9c54
Compare
538f27d
to
3db7cfc
Compare
@weiquu Thanks wq! Have made the changes. Will request for review once checks are completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's fix the other tests only after the current round of E2E tests migration is done
871f822
into
TEAMMATES:multiple-course-structures
Part of #12946.
Outline of Solution
As per title.
For reference: #12948.