[#12666] Instructor's Student Records Page: Moderate response button (on panel) #12964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a propagation stop to the moderate response button
weiquu
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12666
Outline of Solution
1- Moderate Response on Open Panel
On the feedback session records, when moderate response button is clicked while the panel is open, instead of leading the user to the moderate response link it was collapsing the panel. This was happening because the click event was propagating to the collapse button. To fix it I added (click)="$event.stopPropagation() to the tm-response-moderation-button in the teammates\src\web\app\components\question-responses\grq-rgq-view-responses\grq-rgq-view-responses.component.html file. This stopped it from propagating to the collapse button.
2- Moderate Response button not clickable in Screen Reader mode
Narrator.mp4
In the video above, I managed to click on the moderate response button using screen reader. However, this wasn't due to my fix since I was able to do it before fixing the issue.