[#12048] Migrate feedback results page E2E test #12949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mingyuanc, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
mingyuanc
changed the title
jayasting98
changed the title
mingyuanc
force-pushed
the
12048-migrate-feedback-results-page
branch
2 times, most recently
from
e9416e1 to
bd326a0
Compare
Fix lint Rerun test Fix lint Retry lint [TEAMMATES#12048] Configure connection pool using hikari (TEAMMATES#12978) * Configure hikari * Remove spacing * Lint [TEAMMATES#12048] Update liquibase configuration (TEAMMATES#12930) * Update gradle config * Update liquibase config for v9 * Turn off table generate for prod * Update of changelog file * Add configuration for generating changelog * Add schema migration docs --------- Co-authored-by: FergusMok <[email protected]> [TEAMMATES#12048] Migrate AccountRequestsLogicTest (TEAMMATES#12780) * Migrate test cases for AccountRequestsLogic * Remove test case * Split test cases [TEAMMATES#12048] Migrate AdminSearchPageE2ETest SQL (TEAMMATES#12811) * test e2e changes * fix: reduce e2e test json file size * fix student key * fix course key * fix instructor keys * fix filepath * fix e2e test * remove extra data from bundle * Add correct removal logic to avoid constraint violation * Fix e2e tests and lint fix reset google id test fix e2e tests fix e2e tests fix tests remove double click fix unknown symbol add toast check change toast verification message remove toast check * fix: add null check * move admin search page e2e test to sql cases * Rename AdminSearchPageE2ETest_SQLEntities.json to AdminSearchPageE2ETest_SqlEntities.json * fix failing test * fix: remove extra null check * fix: add test to e2e sql xml file * fix function call * remove unnecessary changes * create new file for sql entities * revert unnecessary changes * remove trailing whitespace * add teardown for account requests --------- Co-authored-by: Cedric Ong <[email protected]> [TEAMMATES#12995] Create documentation for unit tests (TEAMMATES#12996) * Create documentation for unit tests * Update docs/unit-testing.md Co-authored-by: Zhang Ziqing <[email protected]> * Update docs/unit-testing.md Co-authored-by: Zhang Ziqing <[email protected]> --------- Co-authored-by: Zhang Ziqing <[email protected]> [TEAMMATES#12048] Remove feedbackSession attributes @fetch annotation (TEAMMATES#12992) * Remove feedbackSession @fetch annotation [TEAMMATES#12048] create skeleton for sql LNP tests (TEAMMATES#12994) * create skelton for sql LNP tests * allow lnp test to access sql storage and ensure sql lnp tests are independant of each other --------- Co-authored-by: Zhang Ziqing <[email protected]> [TEAMMATES#12048] Migrate FeedbackNumScaleQuestionE2ETest (TEAMMATES#12940) * Migrate num scale e2e * Fix team id * Fix bugs Add v9.0.0 tag to liquibase changelog (TEAMMATES#13005) sort courses by id before comparison (TEAMMATES#13003) Co-authored-by: Dominic Lim <[email protected]> Test Test2 Test 3 Test 4 Remove buggy components
mingyuanc
force-pushed
the
12048-migrate-feedback-results-page
branch
from
82227ed to
6d83d59
Compare
|
Folks, This PR seems to be stalling (no activities for the past 74 days). 🐌 😢 |
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Changes:
Migrated FeedbackResultsPageE2ETest
Fix bug in FeedbackResponseLogic.java where assertion always fail
Fix bug in GetSessionResultsAction where QuestionId is not used
Add nullable for lastEditorEmail in FeedbackResponseComment
Fix code in INSTRUCTOR_RESULT case of GetSessionResultAction
Remove check for response of q3comment2 as only one comment will be shown in FE