Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11843] Update GetFeedbackSessionLogsAction to use SQL db #12938

Merged
merged 35 commits into from
Apr 5, 2024
Merged

[#11843] Update GetFeedbackSessionLogsAction to use SQL db #12938

merged 35 commits into from
Apr 5, 2024

Conversation

dishenggg
Copy link
Contributor

Part of #11843

Outline of Solution

  • Action now retrieve logs from FeedbackSessionLogsDB if the course is migrated
  • Added SQL unit test for GetFeedbackSessionLogsAction
  • Added logs into databundle used for testing
  • Added FeedbackSessionLogsLogicIT
  • Updated FeedbackSessionLogsDbIT to use databundle
  • FeedbackSessionLogs are set to cascade delete if their referenced Student or FeedbackSession gets deleted

@dishenggg dishenggg self-assigned this Mar 26, 2024
@dishenggg dishenggg marked this pull request as ready for review March 28, 2024 19:33
@dishenggg dishenggg added s.ToReview The PR is waiting for review(s) and removed s.ToReview The PR is waiting for review(s) labels Mar 28, 2024
@dishenggg dishenggg marked this pull request as draft March 28, 2024 19:37
@dishenggg dishenggg marked this pull request as ready for review March 29, 2024 05:56
@dishenggg dishenggg added the s.ToReview The PR is waiting for review(s) label Mar 29, 2024
FergusMok
FergusMok requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@FergusMok FergusMok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, can try to keep the subsequent PRs more scoped and smaller in size

src/it/resources/data/typicalDataBundle.json Outdated Show resolved Hide resolved
src/main/java/teammates/ui/output/FeedbackSessionLogsData.java Outdated Show resolved Hide resolved
@FergusMok FergusMok requested review from cedricongjh and removed request for cedricongjh April 5, 2024 03:42
cedricongjh
cedricongjh approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work on this!

@cedricongjh cedricongjh merged commit a98630d into TEAMMATES:student-activity-logs Apr 5, 2024
1 check passed
@ziqing26 ziqing26 added this to the V9.0.0-beta.5 milestone Apr 19, 2024
@cedricongjh cedricongjh mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricongjh cedricongjh cedricongjh approved these changes

@FergusMok FergusMok FergusMok approved these changes

Assignees

@dishenggg dishenggg

Labels
s.ToReview The PR is waiting for review(s)
Projects
None yet
Milestone
V9.0.0-beta.5
Development

Successfully merging this pull request may close these issues.
4 participants
@dishenggg @FergusMok @cedricongjh @ziqing26