Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12725] Update backend libraries versions, support Java 21 #12885

Merged
merged 5 commits into from
Apr 18, 2024
Merged

[#12725] Update backend libraries versions, support Java 21 #12885

merged 5 commits into from
Apr 18, 2024

Conversation

wkurniawan07
Copy link
Member

@wkurniawan07 wkurniawan07 commented Mar 10, 2024 •
edited
Loading

Part of #12725

Outline of Solution

  • Updated all the backend libraries to the latest at the point of writing (18 Apr 2024), such that they all support Java 11, 17, and 21
    • Exception is made for the Jetty framework, as Jetty 12 only supports Java 17+
  • Updated GitHub Actions versions to their latest major versions
  • Added component test + lint workflow for Java 21
  • Code changes from this PR can be attributed to either:
    • New violations raised by PMD, due to a major version upgrade
    • Movement from javax.* namespace to jakarta.* namespace, as part of Jetty 10 to 11 upgrade
    • Movement from JUnit 4 to JUnit Jupiter

@wkurniawan07 wkurniawan07 force-pushed the java17 branch 4 times, most recently from 6b71b60 to ba3cb2e Compare March 15, 2024 17:02
@wkurniawan07 wkurniawan07 force-pushed the java17 branch 2 times, most recently from 8de059c to 85f8214 Compare March 23, 2024 21:31
@wkurniawan07 wkurniawan07 force-pushed the java17 branch 5 times, most recently from 195b5b4 to 7314f78 Compare March 31, 2024 17:03
@wkurniawan07 wkurniawan07 added this to the V9.0.0-beta.4 milestone Apr 1, 2024
@wkurniawan07 wkurniawan07 force-pushed the java17 branch 2 times, most recently from 9ed01a4 to bf79946 Compare April 3, 2024 01:46
@wkurniawan07 wkurniawan07 force-pushed the java17 branch 4 times, most recently from eee2e3a to efa60de Compare April 8, 2024 02:00
@wkurniawan07 wkurniawan07 marked this pull request as ready for review April 8, 2024 02:29
@wkurniawan07 wkurniawan07 marked this pull request as draft April 8, 2024 02:44
@wkurniawan07 wkurniawan07 removed this from the V9.0.0-beta.5 milestone Apr 8, 2024
@wkurniawan07 wkurniawan07 changed the title [#12725] Make Java 17 the default version [#12725] Update backend libraries versions, support Java 21 Apr 9, 2024
@wkurniawan07 wkurniawan07 added this to the V9.0.0-beta.5 milestone Apr 9, 2024
@wkurniawan07 wkurniawan07 marked this pull request as ready for review April 9, 2024 01:17
@wkurniawan07 wkurniawan07 force-pushed the java17 branch 3 times, most recently from a65436a to c44de39 Compare April 12, 2024 02:59
@wkurniawan07 wkurniawan07 force-pushed the java17 branch 5 times, most recently from 064c96b to 49712c8 Compare April 18, 2024 07:13
@ziqing26 ziqing26 added s.Ongoing The PR is being worked on by the author(s) c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Apr 18, 2024
@ziqing26 ziqing26 added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Apr 18, 2024
cedricongjh
cedricongjh approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ziqing26
ziqing26 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ziqing26 ziqing26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ziqing26 ziqing26 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Apr 18, 2024
@ziqing26 ziqing26 merged commit acc16f2 into TEAMMATES:master Apr 18, 2024
11 checks passed
@wkurniawan07 wkurniawan07 deleted the java17 branch April 18, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziqing26 ziqing26 ziqing26 approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

@weiquu weiquu Awaiting requested review from weiquu

Assignees

@wkurniawan07 wkurniawan07

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V9.0.0-beta.5
Development

Successfully merging this pull request may close these issues.
3 participants
@wkurniawan07 @cedricongjh @ziqing26