-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12588] Improve test code coverage of QuestionResponsePanelComponent #12867
[#12588] Improve test code coverage of QuestionResponsePanelComponent #12867
Conversation
It seems I mistakenly add an unexpected file |
Make a copy of the entire folder first just in case. Then give this command a try: Commit and push like a regular commit. |
I have removed the unnecessary file and it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test cases LGTM, could I trouble you to add the method that is being tested in the test string e.g. it('canUserSeeResponse: should allow instructors to see responses when intent is INSTRUCTOR_RESULT'), this is something we are doing for newly added test cases as it makes it easier for future developers to see exactly which method is being tested
I only added tested methods for the newly created tests. Or do I need to add for all of them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your contribution!
Part of #12588
Outline of Solution
I added a few tests to cover the uncovered code.
I tried to cover everything. It's ready for review.
I only fix the test for one component, so I use the description "Part of #12588".