[#12048] Migrate GetFeedbackSessionLogsAction #12862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricongjh
added
s.FinalReview
ziqing26
added
s.ToMerge
weiquu
added
the
c.Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Couldn't create an alternate constructor because the generic types used in
Map<String, *>are erased, so constructors will conflict. I instead used generic types for the 2 affected constructors, and placed all the type checks inFeedbackSessionLogDatato reduce messiness. Also left a comment so that after migration is done, the generic types can be replaced with the actual types used (i.e.FeedbackSessionandStudent)