Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Add SQL injection tests in NotificationDbIT #12858

Merged
merged 3 commits into from
Mar 2, 2024
Merged

[#12048] Add SQL injection tests in NotificationDbIT #12858

merged 3 commits into from
Mar 2, 2024

Conversation

jayasting98
Copy link
Contributor

Part of #12048

Outline of Solution

SQL injection tests were added into NotificationsDbIT, covering methods, and inputs, except non-string input, and methods with no user input.

@jayasting98 jayasting98 added s.Ongoing The PR is being worked on by the author(s) c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Feb 28, 2024
@jayasting98 jayasting98 added this to the V9.0.0-beta.0 milestone Feb 28, 2024
@jayasting98 jayasting98 self-assigned this Feb 28, 2024
@jayasting98 jayasting98 added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Feb 29, 2024
@jayasting98 jayasting98 marked this pull request as ready for review February 29, 2024 02:03
weiquu
weiquu approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for commenting the SQL statement

@weiquu weiquu added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Feb 29, 2024
cedricongjh
cedricongjh approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cedricongjh cedricongjh merged commit 36c2b32 into TEAMMATES:master Mar 2, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

@EuniceSim142 EuniceSim142 Awaiting requested review from EuniceSim142

Assignees

@jayasting98 jayasting98

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.FinalReview The PR is ready for final review
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jayasting98 @weiquu @cedricongjh