[#12048] Add SQL injection tests in FeedbackSessionsDbIT #12857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayasting98
added
s.Ongoing
jayasting98
added
s.ToReview
EuniceSim142
reviewed
Mar 7, 2024
src/it/java/teammates/it/storage/sqlapi/FeedbackSessionsDbIT.java
Outdated
Show resolved
Hide resolved
weiquu
added
s.ToMerge
jayasting98
added a commit
to jayasting98/teammates
that referenced
this pull request
Mar 18, 2024
…AMMATES#12857) * Add createTypicalXyz methods * Add SQL injection tests for createFeedbackSession * Add SQL injection tests for getFeedbackSession(String, String) * Add SQL injection tests for getSoftDeletedFeedbackSession * Add SQL injection test for getSoftDeletedFeedbackSessionsForCourse * Add SQL injection tests from restoreDeletedFeedbackSession * Change SQL injection for restoreDeletedFeedbackSession * Add SQL injection test for getFeedbackSessionEntitiesForCourse * Add SQL injection test for get ... for course starting after * Add comment for SQL injection attempts on deleteFeedbackSession * Add SQL injection tests for updateFeedbackSession * Add SQL injection tests for softDeleteFeedbackSession * Fix lint * Fix PMD * Make SQL injection query more concise --------- Co-authored-by: Wei Qing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
SQL injection tests were added into
FeedbackSessionsDbIT, covering almost every method, and every input, except non-string input, input strings which disallowed single quotation marks, and methods with no user input.Also, the column type of the instructions of a feedback session was changed to be
TEXT, instead ofVARCHAR, to allow for much longer text, which was used in the tests. I believe the previous limit was not intended.