Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] SQL injection test for UsersDbIT #12851

Merged
merged 5 commits into from
Mar 2, 2024
Merged

[#12048] SQL injection test for UsersDbIT #12851

merged 5 commits into from
Mar 2, 2024

Conversation

cedricongjh
Copy link
Contributor

Part of #12048

Outline of Solution
Added sql injection tests to relevant methods in UsersDb

weiquu
weiquu reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise lgtm

src/it/java/teammates/it/storage/sqlapi/UsersDbIT.java Outdated Show resolved Hide resolved
@jayasting98 jayasting98 added s.ToReview The PR is waiting for review(s) c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Feb 29, 2024
@jayasting98 jayasting98 added this to the V9.0.0-beta.0 milestone Feb 29, 2024
jayasting98
jayasting98 requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@jayasting98 jayasting98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may have missed getTeamOrCreate and updateStudent. Or were they left out for a reason?

src/it/java/teammates/it/storage/sqlapi/UsersDbIT.java Outdated Show resolved Hide resolved
@jayasting98 jayasting98 added s.Ongoing The PR is being worked on by the author(s) and removed s.ToReview The PR is waiting for review(s) labels Feb 29, 2024
@cedricongjh
Copy link
Contributor Author

I think you may have missed getTeamOrCreate and updateStudent. Or were they left out for a reason?

that's my bad, i've added the tests for those methods

jayasting98
jayasting98 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@jayasting98 jayasting98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks!

@jayasting98 jayasting98 added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Mar 1, 2024
@weiquu
Copy link
Contributor

weiquu commented Mar 1, 2024

@cedricongjh some lint checks failing

weiquu
weiquu approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cedricongjh cedricongjh merged commit c87457c into TEAMMATES:master Mar 2, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayasting98 jayasting98 jayasting98 approved these changes

@weiquu weiquu weiquu approved these changes

@EuniceSim142 EuniceSim142 Awaiting requested review from EuniceSim142

Assignees

@cedricongjh cedricongjh

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.FinalReview The PR is ready for final review
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cedricongjh @weiquu @jayasting98