-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12048] Migrate AdminSearchPageE2ETest #12838
[#12048] Migrate AdminSearchPageE2ETest #12838
Conversation
…om/domoberzin/teammates into migrate-admin-search-page-e2e-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the work on this, just some nits
…om/domoberzin/teammates into migrate-admin-search-page-e2e-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small question, otherwise LGTM! Great work (:
…om/domoberzin/teammates into migrate-admin-search-page-e2e-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of #12048
Outline of Solution
This PR migrates Account and AccountRequests used in this E2E test only.
The necessary cleanup methods are also implemented, as well as a method to remove search documents for AccountRequest. Note that when uploaded to Solr, the entry id's are prefixed with
java.util.UUID:
, hence removal of the document is done with the appended prefix as well.This also fixes the issue with searching, that occurred due to the following original execution pathway:
/sqlsearch/SearchManager.java
Here is a video documenting an example execution, on the right screen is a direct call to the locally hosted solr for all search results, on the left is an execution of search via the admin search page. Once the search is executed from the admin page, the solr results on the right become empty.
Screen.Recording.2024-02-26.at.10.44.43.AM.mov
Additionally, in the equivalent code for non-sql search in
/search/SearchManager.java
, so nulls can be added to the result list as there is no handling for it, and the resultant conversion to output data will throw an NPE when properties of the entity are accessed.