Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Move accounts JSON for AdminSessionsPageE2ETest #12802

Merged
merged 1 commit into from
Feb 25, 2024
Merged

[#12048] Move accounts JSON for AdminSessionsPageE2ETest #12802

merged 1 commit into from
Feb 25, 2024

Conversation

weiquu
Copy link
Contributor

@weiquu weiquu commented Feb 25, 2024

Part of #12048

@weiquu weiquu requested a review from EuniceSim142 February 25, 2024 05:29
cedricongjh
cedricongjh approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EuniceSim142
EuniceSim142 approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@EuniceSim142 EuniceSim142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cedricongjh cedricongjh added the s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging label Feb 25, 2024
@EuniceSim142 EuniceSim142 merged commit 3a21860 into TEAMMATES:master Feb 25, 2024
7 of 10 checks passed
@cedricongjh cedricongjh added this to the V9.0.0-beta.0 milestone Mar 10, 2024
@FergusMok FergusMok added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EuniceSim142 EuniceSim142 EuniceSim142 approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees

@weiquu weiquu

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
4 participants
@weiquu @cedricongjh @EuniceSim142 @FergusMok