-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12048] Migrate Admin Notifications E2E Test #12793
Merged
cedricongjh
merged 14 commits into
TEAMMATES:master
from
domoberzin:feat/migrate-admin-notifications-e2e
Feb 25, 2024
Merged
[#12048] Migrate Admin Notifications E2E Test #12793
cedricongjh
merged 14 commits into
TEAMMATES:master
from
domoberzin:feat/migrate-admin-notifications-e2e
Feb 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/domoberzin/teammates into feat/migrate-admin-notifications-e2e
cedricongjh
approved these changes
Feb 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
cedricongjh
added
the
s.ToMerge
The PR is approved by all reviewers including final reviewer; ready for merging
label
Feb 25, 2024
weiquu
added
the
c.Task
Other non-user-facing works, e.g. refactoring, adding tests
label
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution