Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate instructor notification page e2e test #12792

Conversation

dishenggg
Copy link
Contributor

Part of #12048

Outline of Solution

Update test to use sqlentity

@cedricongjh cedricongjh self-requested a review February 24, 2024 09:31
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cedricongjh cedricongjh added the s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging label Feb 24, 2024
@cedricongjh cedricongjh merged commit 8125d53 into TEAMMATES:master Feb 24, 2024
6 of 9 checks passed
@cedricongjh cedricongjh added this to the V9.0.0-beta.0 milestone Mar 10, 2024
@FergusMok FergusMok added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants