Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate instructor courses page e2e test #12789

Merged

Conversation

cedricongjh
Copy link
Contributor

Part of #12048

Outline of Solution
Revert CreateCourseAction to create courses in datastore
Create account in sql

@cedricongjh cedricongjh requested a review from weiquu February 24, 2024 08:24
@weiquu weiquu changed the title [#12048] Migrate instructor courses page e2 e test [#12048] Migrate instructor courses page e2e test Feb 24, 2024
Copy link
Contributor

@EuniceSim142 EuniceSim142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch on the action

@weiquu weiquu added the s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging label Feb 24, 2024
@weiquu weiquu added this to the V9.0.0-beta.0 milestone Feb 24, 2024
@cedricongjh cedricongjh merged commit 1d9011f into TEAMMATES:master Feb 24, 2024
6 of 9 checks passed
@FergusMok FergusMok added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants