[#12048] SQL injection test for AccountRequestsDbIT #12788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EuniceSim142
requested changes
Feb 24, 2024
src/it/java/teammates/it/storage/sqlapi/AccountRequestsDbIT.java
Outdated
Show resolved
Hide resolved
jayasting98
reviewed
Feb 25, 2024
src/it/java/teammates/it/storage/sqlapi/AccountRequestsDbIT.java
Outdated
Show resolved
Hide resolved
Updated with these tests! |
jayasting98
approved these changes
Feb 29, 2024
Comment on lines
+186
to
+189
| String emailInjection = "email'/**/OR/**/1=1/**/@gmail.com"; | ||
| String nameInjection = "name'; DROP TABLE account_requests; --"; | ||
| String instituteInjection = "institute'; DROP TABLE account_requests; --"; | ||
| AccountRequest accountRequestInjection = new AccountRequest(emailInjection, nameInjection, instituteInjection); |
There was a problem hiding this comment.
Nice. Actually, I should have combined everything in one shot like you did.
| accountRequestDb.createAccountRequest(accountRequest); | ||
|
|
||
| String searchInjection = "institute'; DROP TABLE account_requests; --"; | ||
| List<AccountRequest> actualInjection = accountRequestDb.searchAccountRequestsInWholeSystem(searchInjection); |
There was a problem hiding this comment.
Does this use SQL? I thought it's Solr. Still, I guess there's no harm, and it's possible the implementation may change to use SQL, but I'm not sure it's likely, even if PostgreSQL can do full-text search.
jayasting98
added
s.FinalReview
EuniceSim142
approved these changes
Mar 4, 2024
EuniceSim142
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048