[#12048] Migrate student notification page e2e test #12773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricongjh
commented
Feb 23, 2024
Comment on lines
+354
to
+360
| .orShould().accessClassesThat(new DescribedPredicate<>("") { | ||
| @Override | ||
| public boolean apply(JavaClass input) { | ||
| return input.getPackageName().startsWith(UI_PACKAGE) | ||
| && !input.getPackageName().startsWith(UI_OUTPUT_PACKAGE); | ||
| } | ||
| }) |
There was a problem hiding this comment.
wld like to point this out, here we are letting e2e tests access the output, as its needed to do assertions (the old way with datastore was to convert the Data to the actual DTO, but that cannot be done now as the Data does not actually contain all the required fields to create the entity (this is due to SQL being relational, e.g. return FeedbackResponseData, we do not actually have the full course to create the entity)
see AbstractBackDoor.java for examples of how this Data -> Entity is done in datastore, and i think its not possible for our new SQL setup
ziqing26
approved these changes
Feb 24, 2024
Comment on lines
+111
to
+113
| public void verifyNotificationTab(Notification notification, Set<String> readNotificationIds) { | ||
| boolean isRead = readNotificationIds.contains(notification.getId().toString()); | ||
| WebElement notificationTab = notificationTabs.findElement(By.id(notification.getId().toString())); |
There was a problem hiding this comment.
This is much cleaner than putting id in the title, thanks for the change
FergusMok
added
the
c.Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Persist ReadNotifications in data bundle
Add removeAndStoreSqlDataBundle to e2e base test case
Split out the non-course related entities into its own bundle to be loaded
Migrated the page object methods to use sqlentity
Removed some code that checked if account was migrated for certain actions
Return SqlDataBundle so we can read the ID