Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12588] Add tests to question constraint #12747

Merged

Conversation

cedricongjh
Copy link
Contributor

Part of #12588

Outline of Solution
Add unit tests for improve codecov for questionconstraint: https://app.codecov.io/github/TEAMMATES/teammates/tree/master/src%2Fweb%2Fapp%2Fcomponents%2Fquestion-types%2Fquestion-constraint

utilised new builder, placed them in the test file instead of a central location (lmk if theres any comments on this)

also for descriptions, i would like to propose that we include the method name that we are testing if it is a test for a particular function, which is the way its done in this PR

Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, looks clean with the builder

@cedricongjh cedricongjh merged commit 2ae2446 into TEAMMATES:master Feb 17, 2024
9 checks passed
cedricongjh added a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
* create tests for constsum-recipient-question-constraint

* add unit tests for ContributionQuestionConstraintComponent

* fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants