[#12664] Instructor's Student Records Page: Accessibility issue for comment buttons #12683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlimm
reviewed
Dec 30, 2023
There was a problem hiding this comment.
Hello @rahulpro2001, do fix the lint issues as well as the failing snapshot tests before we proceed to review your work. You may update the snapshots by running npm run test and pressing a to run all test cases. After that, check through the snapshots to make sure the changes are as expected, then press u to update them. You can find more details on snapshot testing here.
| <i class="fas fa-save"></i> {{ mode === CommentRowMode.EDIT ? 'Save' : 'Add' }} | ||
| </button> | ||
| </span> | ||
| </div> |
There was a problem hiding this comment.
Nit: let's keep the newline at the end of file.
| </div> | ||
| </div> | ||
| <div class="comment-text col-12" [innerHTML]="model.originalComment.commentText | safeHtml"></div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12664
Outline of Solution