Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12466] Docs: Clarify masquerade mode #12595

Merged
merged 2 commits into from
Oct 2, 2023
Merged

[#12466] Docs: Clarify masquerade mode #12595

merged 2 commits into from
Oct 2, 2023

Conversation

jasonqiu212
Copy link
Contributor

Fixes #12466

@jasonqiu212 jasonqiu212 added the s.ToReview The PR is waiting for review(s) label Sep 29, 2023
domlimm
domlimm approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domlimm domlimm added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Oct 1, 2023
weiquu
weiquu approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weiquu weiquu merged commit defc75f into TEAMMATES:master Oct 2, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu approved these changes

@domlimm domlimm domlimm approved these changes

@cedricongjh cedricongjh Awaiting requested review from cedricongjh

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

Clarify masquerade mode in docs
4 participants
@jasonqiu212 @domlimm @weiquu @wkurniawan07