Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12480] Add a trigger for good first issues #12560

Merged
merged 32 commits into from
Sep 16, 2023
Merged

[#12480] Add a trigger for good first issues #12560

merged 32 commits into from
Sep 16, 2023

Conversation

nagarajan-ck
Copy link
Contributor

@nagarajan-ck nagarajan-ck commented Aug 18, 2023 •
edited
Loading

Fixes #12480

Outline of Solution

The comment is added using github actions script. The comment to be added is appended to the body key of github.rest.issues.createComment.
Originally part of #12490 by athakaras.

Please suggest if any changes are required.

nagarajan-ck and others added 26 commits August 16, 2023 17:00
@nagarajan-ck
add good first issue yaml file
90753e9
@nagarajan-ck
Merge pull request #1 from nagarajan-ck/good-first-issue
3b75ce4 
[TEAMMATES#12480] add good first issue yaml file
@nagarajan-ck
remove error: context.issue is not a function
cb08972
@nagarajan-ck
Merge pull request #3 from nagarajan-ck/good-first-issue
dff91ac 
[TEAMMATES#12480] remove error: context.issue is not a function
@nagarajan-ck
github.issues.createComment in V4 becomes github.rest.issues.createCo…
647b79b 
…mment in V5
@nagarajan-ck
Merge pull request #5 from nagarajan-ck/good-first-issue
3e6d230 
[TEAMMATES#12480] change github.issues.createComment to github.rest.issues.createComment
@nagarajan-ck
Merge branch 'master' into good-first-issue
44f3e94
@nagarajan-ck
Merge pull request #8 from nagarajan-ck/good-first-issue
3b23b82 
Merge master into good first issue branch
@nagarajan-ck
change message to be TEAMMATES specific
2f26db1
@nagarajan-ck
Merge pull request #9 from nagarajan-ck/good-first-issue
dd9557a 
change message to be TEAMMATES specific
@nagarajan-ck
resolve unexpected identifier issue
ced14cc
@nagarajan-ck
Merge pull request #11 from nagarajan-ck/good-first-issue
900c7c9 
resolve unexpected identifier issue
@nagarajan-ck
put messages in seperate lines
b44ee39
@nagarajan-ck
Merge pull request #13 from nagarajan-ck/good-first-issue
933a39e 
put messages in seperate lines
@nagarajan-ck
put messages in env variable
3826d88
@nagarajan-ck
Merge pull request #15 from nagarajan-ck/good-first-issue
d479d50 
put messages in env variable
@nagarajan-ck
put 2 whitespaces for a newline
0747443
@nagarajan-ck
Merge pull request #16 from nagarajan-ck/good-first-issue
b8f6d2b 
put 2 whitespaces for a newline
@nagarajan-ck
Add new lines between message
d1b335d
@nagarajan-ck
Update comment-goodfirstissue.yml
540a78f
@nagarajan-ck
Add 2 lines
b1d887a
@nagarajan-ck
add 3rd and 4th line
f938cf0
@nagarajan-ck
put message in body variable
0c7967c
@nagarajan-ck
Merge branch 'master' into test-gfs
324d5fc
@nagarajan-ck
Merge branch 'master' into test-gfs
45c61b5
@nagarajan-ck
Merge pull request #21 from nagarajan-ck/test-gfs
658a2d4 
Test gfs
@github-actions
Copy link

Hi @nagarajan-ck, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢
Hope someone can get it to move forward again soon...

@zhaojj2209
Copy link
Contributor

@nagarajan-ck Apologies for the late review. Please note my comment in #12490.

We are currently using actions/github-script@v6 for our PR checker workflow. Could you switch to using v6 instead of v5 for this workflow as well for consistency?

@nagarajan-ck
Copy link
Contributor Author

@zhaojj2209
I have changed the file so that it now uses actions/github-script@v6

@cedricongjh cedricongjh added the s.FinalReview The PR is ready for final review label Sep 8, 2023
cedricongjh
cedricongjh approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for your contribution to TEAMMATES

@zhaojj2209 zhaojj2209 changed the title [12480] Add a trigger for good first issues [#12480] Add a trigger for good first issues Sep 9, 2023
@nagarajan-ck
Copy link
Contributor Author

@zhaojj2209 yes the suggested changes look a lot more simplified, I have commited them.

zhaojj2209
zhaojj2209 approved these changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

@zhaojj2209 zhaojj2209 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Sep 16, 2023
@zhaojj2209 zhaojj2209 merged commit ef058ca into TEAMMATES:master Sep 16, 2023
@wkurniawan07 wkurniawan07 added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
@wkurniawan07 wkurniawan07 added c.DevOps Process-related or build-related improvement and addition and removed c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees
No one assigned
Labels
c.DevOps Process-related or build-related improvement and addition s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

Add a trigger for good first issues
5 participants
@nagarajan-ck @nusoss-bot @zhaojj2209 @cedricongjh @wkurniawan07