[#11947] Format error toasts #12509
Merged
[#11947] Format error toasts #12509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @domoberzin, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
weiquu
requested changes
Jul 13, 2023
...eb/app/pages-instructor/instructor-course-edit-page/instructor-course-edit-page.component.ts
Outdated
Show resolved
Hide resolved
jasonqiu212
added
the
s.ToMerge
weiquu
approved these changes
Jul 13, 2023
samuelfangjw
added
the
c.Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11947
Outline of Solution
This PR improves the appearance of error toasts by formatting them to separate each error into a new line, by adjusting the
whitespaceCSS property on the toast component.Additionally, due to the adjustment of this property, some of the status messages within the toasts turn up with odd spaces and line breaks. This PR also adds the necessary fixes for those messages.
Lastly, due to the modification, some E2E tests also fail with the odd errors unrelated to toast itself. I found that adding a fixed timeout and closing the toast popup after verification of the message fixes this issue. These changes are also within this PR.