Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12283] Adding button for Download Question Results #12505

Closed

Conversation

NyndoND
Copy link

@NyndoND NyndoND commented Jul 3, 2023

Fixes #12283 Added button for download question results

Outline of Solution
I just created a component and redirected the functions to, create a css class to format the button and I'm trying to implement test to check if it is actually being rendered

@weiquu
Copy link
Contributor

weiquu commented Jul 4, 2023

Hi @NyndoND, there are a couple of issues that I've spotted:

  • There are some imports missing, which you'll need to create the test questions. I'll place them here for convenience:
import { QuestionTabModel } from './instructor-session-result-page.component';
import { FeedbackParticipantType, FeedbackQuestionType, NumberOfEntitiesToGiveFeedbackToSetting } from '../../../types/api-output';
  • Small thing, but the second question should have questionNumber: 2
  • You'll need to add the test questions to the component. You can do so by adding this line before fixture.detectChanges();: component.questions = testQuestions;. This is also the reason why you were unable to select a button
  • Note that the component uses ngFor, meaning it's not clear which button you're selecting... won't be an issue with the test, but it might be better to specify by selecting the button using an id
  • The rest should be fine - just click the button and the test will run correctly.

Hope this helps! I ran the test and it passes for me (:

@NyndoND NyndoND marked this pull request as ready for review July 12, 2023 10:53
@weiquu
Copy link
Contributor

weiquu commented Jul 12, 2023

Hi @NyndoND, do take a look at the failing accessibility tests. You can see more about the error by clicking on the "Details" button next to the test.

@weiquu
Copy link
Contributor

weiquu commented Jul 13, 2023

@NyndoND do note that the component tests are failing!

@weiquu
Copy link
Contributor

weiquu commented Jul 22, 2023

@NyndoND do let us know if you're facing any issues with the component tests, or if you're no longer working on this

@weiquu weiquu closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor view session results (course-wide): Add separate button to download results by question
2 participants