Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12400] Instructor editing questions: warning about visibility is removed if the edit is cancelled. #12495

Merged
merged 3 commits into from
Jun 29, 2023
Merged

[#12400] Instructor editing questions: warning about visibility is removed if the edit is cancelled. #12495

merged 3 commits into from
Jun 29, 2023

Conversation

Zxun2
Copy link
Contributor

@Zxun2 Zxun2 commented Jun 26, 2023

Fixes #12400

Outline of Solution

isQuestionHasResponses of questionEditFormModel was set back to default when discard action was executed. I simply mutated the new questionEditFormModel created with the previous isQuestionHasResponses status.

Demo

Fix.glitch.on.instructor.edit.form.mp4

@domlimm domlimm added the s.ToReview The PR is waiting for review(s) label Jun 26, 2023
weiquu
weiquu approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing

@weiquu weiquu added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Jun 27, 2023
domlimm
domlimm approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@domlimm domlimm added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jun 28, 2023
@weiquu weiquu merged commit f1423d1 into TEAMMATES:master Jun 29, 2023
Zxun2 added a commit to Zxun2/teammates that referenced this pull request Jul 12, 2023
@Zxun2 @domlimm
fix: warning visibility on edit (TEAMMATES#12495)
803eae4 
Co-authored-by: Dominic Lim <[email protected]>
@samuelfangjw samuelfangjw added the c.Bug Bug/defect report label Jul 14, 2023
@samuelfangjw samuelfangjw added this to the V8.28.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domlimm domlimm domlimm approved these changes

@weiquu weiquu weiquu approved these changes

Assignees

@domlimm domlimm

@weiquu weiquu

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.28.0
Development

Successfully merging this pull request may close these issues.

Instructor editing questions: warning about visibility is removed if the edit is cancelled.
4 participants
@Zxun2 @domlimm @weiquu @samuelfangjw