Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1501] Add tests cases to FeedbackRankOptionsQuestionDetails #12475

Merged
merged 5 commits into from
Jun 26, 2023
Merged

[#1501] Add tests cases to FeedbackRankOptionsQuestionDetails #12475

merged 5 commits into from
Jun 26, 2023

Conversation

leonardomilv3
Copy link
Contributor

Part of #1501

Outline of Solution

Approach:

  • Based on jacoco reports and the coverage of the method validateQuestionDetails
  • I applied mulitple-conditions white-box test
  • And added 2 tests cases to cover 100% of the method
  • In the test method testValidateQuestionDetails_invalidMaxMinOptions_errorReturned

@leonardomilv3
Update FeedbackRankOptionsQuestionDetailsTest.java
d82d3c4 
Adding test case to
testValidateQuestionDetails_invalidMaxMinOptions_errorReturned()
@leonardomilv3
Merge branch 'TEAMMATES:master' into master
ef9f307
@leonardomilv3
Update FeedbackRankOptionsQuestionDetailsTest.java
6129a3e 
Adding new test case to FeedbackRankOptionsQuestionDetailsTest
weiquu
weiquu approved these changes Jun 18, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing

@weiquu weiquu added the s.FinalReview The PR is ready for final review label Jun 18, 2023
@weiquu weiquu requested a review from domlimm June 25, 2023 00:25
domlimm
domlimm approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@domlimm domlimm added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jun 25, 2023
@weiquu weiquu merged commit bc1e5f5 into TEAMMATES:master Jun 26, 2023
Zxun2 pushed a commit to Zxun2/teammates that referenced this pull request Jul 12, 2023
@leonardomilv3 @domlimm
@weiquu @Zxun2
[TEAMMATES#1501] Add tests cases to FeedbackRankOptionsQuestionDetails (
b0a3bdd 
TEAMMATES#12475)

* Update FeedbackRankOptionsQuestionDetailsTest.java

Adding test case to
testValidateQuestionDetails_invalidMaxMinOptions_errorReturned()

* Update FeedbackRankOptionsQuestionDetailsTest.java

Adding new test case to FeedbackRankOptionsQuestionDetailsTest

---------

Co-authored-by: Dominic Lim <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
@samuelfangjw samuelfangjw added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Jul 14, 2023
@samuelfangjw samuelfangjw added this to the V8.28.0 milestone Jul 14, 2023
@FergusMok FergusMok mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domlimm domlimm domlimm approved these changes

@weiquu weiquu weiquu approved these changes

Assignees

@domlimm domlimm

@weiquu weiquu

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@leonardomilv3 @domlimm @weiquu @samuelfangjw