Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10920] Added test for Instructor Course Edit Page #12462

Merged
merged 4 commits into from
Jun 6, 2023
Merged

[#10920] Added test for Instructor Course Edit Page #12462

merged 4 commits into from
Jun 6, 2023

Conversation

justincavalli
Copy link
Contributor

@justincavalli justincavalli commented Jun 4, 2023 •
edited by domlimm
Loading

Part of #10920

Outline of Solution
Tested that Instructor details are correctly updated when SAVE is requested on instructor-course-edit-page

@domlimm domlimm self-requested a review June 4, 2023 15:25
@domlimm domlimm added the s.ToReview The PR is waiting for review(s) label Jun 4, 2023
domlimm
domlimm approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

weiquu
weiquu approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing

@weiquu weiquu merged commit 38341d6 into TEAMMATES:master Jun 6, 2023
@samuelfangjw samuelfangjw added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.ToReview The PR is waiting for review(s) labels Jul 14, 2023
@samuelfangjw samuelfangjw added this to the V8.28.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu approved these changes

@domlimm domlimm domlimm approved these changes

Assignees

@domlimm domlimm

@weiquu weiquu

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@justincavalli @domlimm @weiquu @samuelfangjw