Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12099] Add 'course -> copy' option to the instructor home page #12439

Merged
merged 9 commits into from
Jun 5, 2023
Merged

[#12099] Add 'course -> copy' option to the instructor home page #12439

merged 9 commits into from
Jun 5, 2023

Conversation

damoba
Copy link
Contributor

@damoba damoba commented May 22, 2023 •
edited
Loading

Fixes #12099

Outline of Solution

I've added the course copy element to the html in the instructor home page, added the course copy logic to the typescript files while using functions declared in its ancestor InstructorSessionBasePageComponent, and I also updated the snapshot tests.

@domlimm domlimm added the s.ToReview The PR is waiting for review(s) label May 22, 2023
weiquu
weiquu requested changes May 29, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @damoba for the PR and sorry for the late review! Just 2 comments, otherwise great work (:

src/web/app/pages-instructor/instructor-home-page/instructor-home-page.component.html Outdated Show resolved Hide resolved
src/web/app/pages-instructor/instructor-home-page/instructor-home-page.component.ts Show resolved Hide resolved
weiquu
weiquu approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weiquu weiquu added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels May 30, 2023
@weiquu weiquu requested review from jasonqiu212 and domlimm June 3, 2023 19:19
domlimm
domlimm approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work on catching the extra check! It does make a difference adding that in 👍🏻

@domlimm domlimm added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jun 4, 2023
@domlimm domlimm merged commit e17c33a into TEAMMATES:master Jun 5, 2023
@damoba damoba deleted the add-course-copy branch June 6, 2023 01:44
@samuelfangjw samuelfangjw added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label Jul 14, 2023
@samuelfangjw samuelfangjw added this to the V8.28.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu approved these changes

@domlimm domlimm domlimm approved these changes

@jasonqiu212 jasonqiu212 Awaiting requested review from jasonqiu212

Assignees

@domlimm domlimm

@weiquu weiquu

Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.28.0
Development

Successfully merging this pull request may close these issues.

Add 'course -> copy' option to the instructor home page
4 participants
@damoba @domlimm @weiquu @samuelfangjw