Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12265] Modify minimum page height to factor in footer height #12406

Merged
merged 8 commits into from
Apr 27, 2023
Merged

[#12265] Modify minimum page height to factor in footer height #12406

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
51c8c93
Edited css main-height variable to calculate footer position based on…
Apr 22, 2023
7984a9d
Added another case if the screen width is below 314px (Which will pro…
Apr 22, 2023
d94b221
Removed extra space and end of lines
Apr 22, 2023
1fd310f
Update src/web/app/page.component.scss by removing the footer case fo…
ryalin Apr 23, 2023
6813ade
Removed 590px or above case and below 313px case for screen width
Apr 23, 2023
6f0397c
Removed 590px or above case and below 313px case for screen width
Apr 23, 2023
e0810e0
Merge branch 'master' into min_page_height
ryalin Apr 24, 2023
59978ac
Merge branch 'master' into min_page_height
weiquu Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/web/app/page.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,22 @@ nav {

.main-content {
margin-top: 50px;
min-height: calc(100vh - 80px);
min-height: calc(100vh - 102px);
padding: 20px 70px;
}

@media (max-width: 575px) {
.main-content {
min-height: calc(100vh - 144px);
}
}

@media (min-width: 576px) and (max-width: 589px) {
.main-content {
min-height: calc(100vh - 123px);
}
}

.footer {
padding: 5px 70px;
color: rgba(255, 255, 255, .75);
Expand Down