Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1501] Create Unit Tests for FeedbackConstantSumQuestionDetails class #12402

Merged
merged 4 commits into from
Apr 23, 2023
Merged

[#1501] Create Unit Tests for FeedbackConstantSumQuestionDetails class #12402

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d96a2d9
tests added for validateQuestionDetails method in FeedbackConstantSum…
landa44 Apr 21, 2023
5c3a66c
increasing coverage for validateQuestionDetails method in FeedbackCon…
landa44 Apr 21, 2023
da4a4fb
fixing code to passe static analysis
landa44 Apr 21, 2023
a2c137e
Merge branch 'master' into 1501-testing-feedbackConstantSumQuestionDe…
zhaojj2209 Apr 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 86 additions & 0 deletions .../java/teammates/common/datatransfer/questions/FeedbackConstantSumQuestionDetailsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;

import org.testng.annotations.Test;

Expand Down Expand Up @@ -343,4 +344,89 @@ public void testIsFeedbackParticipantCommentsOnResponsesAllowed_shouldReturnFals
FeedbackQuestionDetails feedbackQuestionDetails = new FeedbackConstantSumQuestionDetails();
assertFalse(feedbackQuestionDetails.isFeedbackParticipantCommentsOnResponsesAllowed());
}

@Test
public void testValidateQuestionDetails_invalidMaxMinOptions_errorReturned() {
FeedbackConstantSumQuestionDetails feedbackQuestionDetails =
new FeedbackConstantSumQuestionDetails("Is this a test?");

feedbackQuestionDetails.setConstSumOptions(new ArrayList<>(Arrays.asList("Yes", "No")));
feedbackQuestionDetails.setMinPoint(101);
feedbackQuestionDetails.setMaxPoint(-1);

List<String> errors = feedbackQuestionDetails.validateQuestionDetails();

assertEquals(5, errors.size());
assertTrue(errors.contains(FeedbackConstantSumQuestionDetails.CONST_SUM_ERROR_MIN_GREATER_THAN_MAX));
assertTrue(errors.contains(FeedbackConstantSumQuestionDetails.CONST_SUM_ERROR_MIN_POINT_ABOVE_UPPER_BOUND + "50"));
assertTrue(errors.contains(FeedbackConstantSumQuestionDetails.CONST_SUM_ERROR_MAX_POINT_BELOW_LOWER_BOUND + "50"));
assertTrue(errors.contains(String.format(FeedbackConstantSumQuestionDetails.CONST_SUM_TEMPLATE_NEGATIVE,
FeedbackConstantSumQuestionDetails.MAX_POINT_STRING)));
assertTrue(errors.contains(String.format(FeedbackConstantSumQuestionDetails.CONST_SUM_TEMPLATE_EXCEEDS_POINTS,
FeedbackConstantSumQuestionDetails.MIN_POINT_STRING, 100)));
}

@Test
public void testValidateQuestionDetails_duplicateOptions_errorReturned() {
FeedbackConstantSumQuestionDetails feedbackQuestionDetails = new FeedbackConstantSumQuestionDetails();

feedbackQuestionDetails.setConstSumOptions(new ArrayList<>(Arrays.asList("foo", "No", "foo")));

assertTrue(feedbackQuestionDetails.validateQuestionDetails()
.contains(FeedbackConstantSumQuestionDetails.CONST_SUM_ERROR_DUPLICATE_OPTIONS));
}

@Test
public void testValidateQuestionDetails_invalidConstSumOptionSize_errorReturned() {
FeedbackConstantSumQuestionDetails feedbackQuestionDetails = new FeedbackConstantSumQuestionDetails();

feedbackQuestionDetails.setConstSumOptions(new ArrayList<>(Arrays.asList("foo")));

assertTrue(feedbackQuestionDetails.validateQuestionDetails()
.contains(FeedbackConstantSumQuestionDetails.CONST_SUM_ERROR_NOT_ENOUGH_OPTIONS
+ FeedbackConstantSumQuestionDetails.CONST_SUM_MIN_NUM_OF_OPTIONS + "."));
}

@Test
public void testValidateQuestionDetails_invalidPoint_errorReturned() {
FeedbackConstantSumQuestionDetails feedbackQuestionDetails = new FeedbackConstantSumQuestionDetails();
feedbackQuestionDetails.setPoints(0);

assertTrue(feedbackQuestionDetails.validateQuestionDetails()
.contains(FeedbackConstantSumQuestionDetails.CONST_SUM_ERROR_NOT_ENOUGH_POINTS
+ FeedbackConstantSumQuestionDetails.CONST_SUM_MIN_NUM_OF_POINTS + "."));
}

@Test
public void testValidateQuestionDetails_destributeToRecipients_noMinMaxOptionErrorsReturned() {
FeedbackConstantSumQuestionDetails feedbackQuestionDetails = new FeedbackConstantSumQuestionDetails();

feedbackQuestionDetails.setConstSumOptions(new ArrayList<>(Arrays.asList("foo", "test")));
feedbackQuestionDetails.setMinPoint(101);
feedbackQuestionDetails.setMaxPoint(-1);
feedbackQuestionDetails.setDistributeToRecipients(true);

assertEquals(0, feedbackQuestionDetails.validateQuestionDetails().size());
}

@Test
public void testValidateQuestionDetails_noMinMaxOptions_noMinMaxOptionErrorsReturned() {
FeedbackConstantSumQuestionDetails feedbackQuestionDetails = new FeedbackConstantSumQuestionDetails();

feedbackQuestionDetails.setConstSumOptions(new ArrayList<>(Arrays.asList("foo", "test")));

assertEquals(0, feedbackQuestionDetails.validateQuestionDetails().size());
}

@Test
public void testValidateQuestionDetails_validMinMaxOption_noErrorsReturned() {
FeedbackConstantSumQuestionDetails feedbackQuestionDetails = new FeedbackConstantSumQuestionDetails();

feedbackQuestionDetails.setConstSumOptions(new ArrayList<>(Arrays.asList("foo", "test", "passed")));
feedbackQuestionDetails.setMinPoint(10);
feedbackQuestionDetails.setMaxPoint(100);
feedbackQuestionDetails.setPointsPerOption(true);

assertEquals(0, feedbackQuestionDetails.validateQuestionDetails().size());
}
}