[#12289] Usage statistics and logs page: Improve date/time input on mobile #12394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricongjh
requested changes
Apr 19, 2023
There was a problem hiding this comment.
hi @aorlandou, thank you for opening this PR.
Do fix the failing tests before we proceed to review this PR. Thank you!
|
Hey @cedricongjh, sorry for the late response I got caught up with work, but I will fix the failing tests today. |
zhaojj2209
added
s.FinalReview
cedricongjh
approved these changes
Apr 23, 2023
zhaojj2209
added
s.ToMerge
samuelfangjw
added
the
c.Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12289
Outline of Solution
I made changes to the following files so that the hour selection is besides the date picker instead of below on mobiles:
Logs page after the changes
Usage Statistics page after the changes
