-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12048] Migrate Get Instructors Action #12210
Merged
samuelfangjw
merged 5 commits into
TEAMMATES:v9-migration
from
domlimm:v9-get-instructors-action
Mar 19, 2023
Merged
[#12048] Migrate Get Instructors Action #12210
samuelfangjw
merged 5 commits into
TEAMMATES:v9-migration
from
domlimm:v9-get-instructors-action
Mar 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelfangjw
requested changes
Mar 16, 2023
samuelfangjw
requested changes
Mar 17, 2023
domlimm
force-pushed
the
v9-get-instructors-action
branch
from
March 18, 2023 13:15
5c1e4ea
to
0760bf7
Compare
domlimm
force-pushed
the
v9-get-instructors-action
branch
from
March 18, 2023 15:02
0760bf7
to
bca5021
Compare
samuelfangjw
approved these changes
Mar 19, 2023
samuelfangjw
pushed a commit
that referenced
this pull request
Mar 20, 2023
samuelfangjw
pushed a commit
that referenced
this pull request
Apr 8, 2023
wkurniawan07
added
s.ToMerge
The PR is approved by all reviewers including final reviewer; ready for merging
c.Task
Other non-user-facing works, e.g. refactoring, adding tests
labels
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048.
Things to highlight
Not sure if it is the best way to do this (similar to PR #12211):
As EntitysData class current constructor with EntityAttribute will cause a type erasure problem when adding another constructor taking in a List of different data type.