Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate Get Instructors Action #12210

Merged

Conversation

domlimm
Copy link
Contributor

@domlimm domlimm commented Mar 15, 2023

Part of #12048.

Things to highlight

Not sure if it is the best way to do this (similar to PR #12211):

EntitysData data = new EntitysData();
List<EntityData> entityDataList = entitysForCourse
        .stream()
        .map(EntityData::new)
        .collect(Collectors.toList());

data.setEntitys(entityDataList);

As EntitysData class current constructor with EntityAttribute will cause a type erasure problem when adding another constructor taking in a List of different data type.

@domlimm domlimm marked this pull request as draft March 15, 2023 16:35
@domlimm domlimm marked this pull request as ready for review March 15, 2023 16:52
@domlimm domlimm requested a review from samuelfangjw March 15, 2023 18:33
@domlimm domlimm requested a review from samuelfangjw March 17, 2023 11:18
@domlimm domlimm force-pushed the v9-get-instructors-action branch from 5c1e4ea to 0760bf7 Compare March 18, 2023 13:15
@domlimm domlimm requested a review from samuelfangjw March 18, 2023 13:17
@domlimm domlimm force-pushed the v9-get-instructors-action branch from 0760bf7 to bca5021 Compare March 18, 2023 15:02
@samuelfangjw samuelfangjw merged commit 6e4d648 into TEAMMATES:v9-migration Mar 19, 2023
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V9.0.0-beta.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants