Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate Reset Account Action #12204

Merged
merged 24 commits into from
Mar 18, 2023
Merged

[#12048] Migrate Reset Account Action #12204

merged 24 commits into from
Mar 18, 2023

Conversation

domlimm
Copy link
Contributor

@domlimm domlimm commented Mar 13, 2023

Part of #12048.

Outline of Solution

As per title.

@domlimm domlimm force-pushed the v9-reset-account-action branch from 3d5db29 to 9d0c1c7 Compare March 14, 2023 07:33
@domlimm domlimm marked this pull request as ready for review March 14, 2023 17:45
@domlimm domlimm requested a review from samuelfangjw March 14, 2023 17:45
samuelfangjw
samuelfangjw requested changes Mar 14, 2023
View reviewed changes
src/main/java/teammates/sqllogic/api/Logic.java Outdated Show resolved Hide resolved
src/main/java/teammates/sqllogic/core/UsersLogic.java Outdated Show resolved Hide resolved
src/main/java/teammates/sqllogic/core/UsersLogic.java Outdated Show resolved Hide resolved
src/main/java/teammates/sqllogic/core/UsersLogic.java Outdated Show resolved Hide resolved
src/test/java/teammates/sqllogic/core/AccountsLogicTest.java Outdated Show resolved Hide resolved
src/main/java/teammates/ui/webapi/ResetAccountAction.java Outdated Show resolved Hide resolved
src/main/java/teammates/sqllogic/core/UsersLogic.java Outdated Show resolved Hide resolved
@domlimm domlimm requested a review from samuelfangjw March 15, 2023 02:56
@domlimm domlimm requested a review from samuelfangjw March 15, 2023 08:23
@domlimm domlimm requested a review from samuelfangjw March 16, 2023 16:59
@domlimm domlimm requested a review from samuelfangjw March 17, 2023 09:51
@domlimm domlimm force-pushed the v9-reset-account-action branch from 0e0e3ef to b5b1660 Compare March 18, 2023 10:05
@domlimm domlimm force-pushed the v9-reset-account-action branch from b5b1660 to 51eec60 Compare March 18, 2023 13:10
@domlimm domlimm requested a review from samuelfangjw March 18, 2023 13:11
@samuelfangjw samuelfangjw merged commit b52259d into TEAMMATES:v9-migration Mar 18, 2023
samuelfangjw pushed a commit that referenced this pull request Mar 20, 2023
@domlimm @samuelfangjw
[#12048] Migrate Reset Account Action (#12204)
d82c685
samuelfangjw pushed a commit that referenced this pull request Apr 8, 2023
@domlimm @samuelfangjw
[#12048] Migrate Reset Account Action (#12204)
ca21f35
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V9.0.0-beta.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelfangjw samuelfangjw samuelfangjw approved these changes

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
3 participants
@domlimm @samuelfangjw @wkurniawan07