[#11853] Add stricter checks for potentially destructive question edits #12030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricongjh
force-pushed
the
11853-warning-message-not-shown-when-editing-questions
branch
from
a5d32b4 to
293d6d6
Compare
|
|
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
cedricongjh
force-pushed
the
11853-warning-message-not-shown-when-editing-questions
branch
from
16da6c6 to
710da25
Compare
zhaojj2209
approved these changes
Feb 6, 2023
zhaojj2209
added
s.FinalReview
hhdqirui
added
s.ToMerge
samuelfangjw
added
the
c.Task
samuelfangjw
approved these changes
Feb 7, 2023
samuelfangjw
assigned cedricongjh, hhdqirui, zhaojj2209 and samuelfangjw and unassigned cedricongjh
weiquu
added a commit
to weiquu/teammates
that referenced
this pull request
Feb 18, 2023
…tive question edits (TEAMMATES#12030)" This reverts commit afff7a3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11853
Outline of Solution
Added a check to make sure that if the question is in a session that is published, we show the warning message when the user makes edits.