Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11569] Move app ID and app version configuration out of build.properties #11985

Closed

Conversation

u6867511
Copy link
Contributor

Fixes #11569

Outline of Solution

Moved app ID and app version out of build.properties into gradle.properties

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@hhdqirui
Copy link
Member

Hi @u6867511 please fix the tests before we can review.

@zhaojj2209 zhaojj2209 added the s.Ongoing The PR is being worked on by the author(s) label Nov 2, 2022
@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 10 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 12 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 19 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 22 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 24 days). 🐌 😢
Hope someone can get it to move forward again soon...

@zhaojj2209
Copy link
Contributor

Closing due to inactivity. Feel free to reopen the PR if you would like to resume working on it.

@zhaojj2209 zhaojj2209 closed this Dec 6, 2022
@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 29 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 33 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 36 days). 🐌 😢
Hope someone can get it to move forward again soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move app ID and app version configuration out of build.properties
4 participants