[#4570] Instructor: support previewing results as a student #11859
Conversation
Currently preview shows exactly what the person being previewed sees. The next step is to remove/modify results that shouldn't be visible to the person previewing the results.
Fix code style, update preview results info, update test and snapshot
|
@wkurniawan07 take a quick review? |
|
|
|
@fans2619 is the message about hidden comments shown only when there are actual comments? Or shown even if there are no actual comments? Perhaps the message (for hidden responses) can be revised as |
The message about hidden comments is shown when there is at least one comment hidden for at least one response below. So it's not shown when there's simply no comment.
Sure. |
|
@damithc For the hidden comments, an alternative way is to show only one alert message at question level. Let me know if that's preferred. |
Yes, that might be better (less noisy), if achievable without much extra cost. |
|
I guess it should be achievable and also simpler than the current implementation. I'll change to that later. |
|
@damithc Could you please verify the position of
|
Yes, the location seems fine. Message:
The other message can be revised as follows, to make the two more consistent with each other.
What do you think? If possible, we can use an icon like this at the start of the message to differentiate from other messages. https://fontawesome.com/icons/eye-slash?s=solid |
|
Thanks for the suggestions! 😀 |
|
Updated:
|
|
@damithc Another question is whether it's preferred for the info box to be above or below the page title "Feedback Session Results". Other two pages are putting it below the page title, although I prefer putting it above so that everything below is what the actual respondent sees. You're also welcome to suggest changes to the text in the box.
|
Yes, above-the-heading is probably better. However, follow what other similar pages does and create a separate issue to move the message box in all similar pages. This issue can be left to new contributors. I'm OK with the message content. Do we call them alert boxes or message boxes (which is easier for users to understand)? |
I'm fine with "message box" :-)
|
…4570-preview-results-as-student
fans2619
requested review from
wkurniawan07
and removed request for
wkurniawan07
fans2619
added
s.ToReview
|
Guys, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢 |
|
Guys, This PR seems to be stalling (no activities for the past 11 days). 🐌 😢 |
|
Guys, This PR seems to be stalling (no activities for the past 14 days). 🐌 😢 |
fans2619
added
s.Ongoing
|
Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
@fans2619 Reminder for this PR! |
Hi thanks for the reminder. However, I'd like to continue working on it when it's confirmed that someone will review it immediately after I resolve the conflicts. It doesn't feel good that I resolved conflicts and there was no review, and after a while conflicts appeared again. |
|
Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
2 similar comments
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
Closing due to inactivity. |
Fixes #4570
Outline of Solution
Frontend changes: Add a preview session result panel at the bottom of the instructor session result page. The panel is similar to preview session panel. Clicking "Preview as Student"/"Preview as Instructor" opens the session result page and pass a new query parameter "previewas". The parameter is then passed to backend for further processing.
Backend changes:
In the process of getting session results, if it's in "preview mode", "remove" questions and comments (i.e., do not add those) that are NOT visible to instructors in general. However, take note of the corresponding [questions] and [responses (for comments)]. For [questions], pass the question attributes to frontend (to display brief and details) and set a boolean indicatorhasResponseButNotVisibleForPreview.hasResponseButNotVisibleForPreviewmeans "the question has responses that are viewable for respondent but the question responses are set to be not viewable to instructors". For [responses], just set a boolean indicatorhasCommentNotVisibleForPreview(since the response is visible and should be returned to frontend).hasCommentNotVisibleForPreviewmeans "the response has comments that are viewable for respondent but not viewable to instructors".In the process of getting session results, if it's in "preview mode", "remove" questions and comments (i.e., do not add those) that are NOT visible to instructors in general. However, take note of the corresponding questions. For [questions that have responses which are visible for respondent but the question responses aren't set to be visible to instructors], pass the question attributes to frontend (to display brief and details) and set a boolean indicator
hasResponseButNotVisibleForPreview. For [questions that have comments (on any responses) which are visible to respondent but not visible to instructors], set a boolean indicatorhasCommentNotVisibleForPreview.Some examples of intended behavior:
box containing the commentquestionThe following of this comment are outdated. See the latest comments.
Setting: For this question, giver's name is not visible to instructors in general
What respondent sees:
What previewer sees:
Setting: A comment is not visible to instructors in general
What respondent sees:
What previewer sees:
@damithc I tried to improve the UI, do you think it's better now? It's just the comment alert is shown for every group of responses.