Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructor Session Page: Failed copy feedback session causes page to load forever. #12551

Closed
rexong opened this issue Aug 9, 2023 · 7 comments · Fixed by #12561
Closed

Instructor Session Page: Failed copy feedback session causes page to load forever. #12551

rexong opened this issue Aug 9, 2023 · 7 comments · Fixed by #12561
Labels
good first issue Easy; restricted for first-time contributors

Comments

@rexong
Copy link
Contributor

rexong commented Aug 9, 2023

  • Environment:
    master branch at commit 8633d4e

Problem
The issue is similar/identical to the issue #12507.
When we try to copy the feedback session, if it fails, it will lead to the page loading forever. The only way to stop it is through hard refresh or navigating to another page.

Steps to reproduce

  1. Go to instructor session page.
  2. Click on Copy for any available session.
  3. Select the same course as the selected session.
    image
  4. Click Copy.

Expected behaviour

  • Error toast to be shown
  • Session table should be generated.

Actual behaviour
Page goes into a loading state forever.

Video Demo of Actual Behaviour
https://github.com/TEAMMATES/teammates/assets/66376253/74e424cd-ef1c-4d02-9aef-7d0d9199277c

Additional info

As mentioned, this issue is similar to issue #12507.
To resolve this issue, look at PR #12550
@github-actions github-actions bot mentioned this issue Aug 9, 2023
Open
@cedricongjh cedricongjh added the good first issue Easy; restricted for first-time contributors label Aug 17, 2023
@DamiGbs DamiGbs mentioned this issue Aug 18, 2023
Merged
@Trjindal
Copy link

i would like to work on it

@domlimm
Copy link
Contributor

domlimm commented Aug 23, 2023

@Trjindal Feel free to submit a PR for this issue.

@PKS-formido
Copy link

Can I try to resolve it?

@jasonqiu212
Copy link
Contributor

Hi @PKS-formido, Feel free to submit a PR for this issue :)

@mambalde
Copy link

is anyone working on this?

@PKS-formido
Copy link

@mambalde I am just trying. You can also try to solve the issue. No need to hold up because of me

@Petros1020
Copy link

Hi really nice project i am happy that i found it!
I made a PR about this issue. #12572

Thanks

@Petros1020 Petros1020 mentioned this issue Sep 3, 2023
Closed
jasonqiu212 pushed a commit that referenced this issue Sep 6, 2023
@DamiGbs
[#12551] Sessions page fix (#12561)
ceb0bcf 
* loading fix
* error toast
* Revert "error toast"
* fixed formatting by reverting commit
* Remove toast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Easy; restricted for first-time contributors
Projects
None yet
Milestone
No milestone
8 participants
@jasonqiu212 @Petros1020 @domlimm @mambalde @rexong @cedricongjh @Trjindal @PKS-formido