Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flickering questions when loading sessions results #12499

Closed
Zxun2 opened this issue Jun 29, 2023 · 12 comments · Fixed by #12570
Closed

Flickering questions when loading sessions results #12499

Zxun2 opened this issue Jun 29, 2023 · 12 comments · Fixed by #12570
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.Low Very little impact; unlikely to do in the near future

Comments

@Zxun2
Copy link
Contributor

Zxun2 commented Jun 29, 2023

  • Environment: master

Steps to reproduce

  • Go to instructor home page
  • Select the first session of the demo course
  • Select "View results (from/to me)"

image

Expected behaviour

  • There should be no flickering

Actual behaviour

flickering-ui-bug-before.mp4

Additional info

  • The questions defaults to hasResponse: true which causes the bug
@github-actions github-actions bot mentioned this issue Jun 29, 2023
Open
@weiquu weiquu added a-UIX User Interface, User eXperience, responsiveness p.Low Very little impact; unlikely to do in the near future good first issue Easy; restricted for first-time contributors labels Jul 3, 2023
@tushargupta123
Copy link

Hey can i correct the issue ?

@domlimm
Copy link
Contributor

domlimm commented Jul 18, 2023

@tushargupta123 Hello, feel free to submit a PR for this.

This was referenced Jul 23, 2023
Open
Open
Open
Open
Open
Open
@rajatmohan22
Copy link

@domlimm Hi, is this issue already assigned to someone? because if not i'll definitely contribute a PR within the next 2-3 days

@jasonqiu212
Copy link
Contributor

Hi @rajatmohan22, feel free to submit a PR for this issue!

@OpherM
Copy link

OpherM commented Aug 10, 2023

Hey Please is this issue still open?

@jasonqiu212
Copy link
Contributor

Hi @OpherM, Someone else has indicated interest in fixing this issue. Could you look into another issue instead? Thanks!

@HarshSingh21
Copy link

Hi,
Can I get assigned to this role? I would love to contribute.

@jasonqiu212
Copy link
Contributor

Hi @HarshSingh21, Please feel free to submit a PR for this issue!

@blejkowski
Copy link
Contributor

Hi @jasonqiu212, is this issue still available? I believe I have figured it out and got a working solution, will send a PR for this issue if allowed to do so. Thanks

blejkowski added a commit to blejkowski/teammates that referenced this issue Aug 30, 2023
@blejkowski
[TEAMMATES#12499] Fixed flickering questions when loading feedback se…
6c002e9 
…ssion results.
@blejkowski blejkowski mentioned this issue Aug 30, 2023
Merged
@Sourav-Kumar-Panda
Copy link

Sourav-Kumar-Panda commented Sep 12, 2023 •
edited
Loading

Hii,
Can I get assigned to this role?

@jasonqiu212
Copy link
Contributor

Hi @Sourav-Kumar-Panda, Thank you for your interest in working on TEAMMATES! Someone is already working on this issue in #12570. I would recommend to find another issue to work on! :)

@Sourav-Kumar-Panda
Copy link

Ok, No problem.

jasonqiu212 added a commit that referenced this issue Sep 15, 2023
@blejkowski @jasonqiu212
[#12499] Flickering questions when loading session results (#12570)
ed3d5f0 
* [#12499] Fixed flickering questions when loading feedback session results.

* Update question-response-panel.component.ts

* Update question-response-panel.component.ts

* Update question-response-panel.component.ts

* Update session-result-page.component.spec.ts

* Update question-response-panel.component.ts

* Update question-response-panel.component.ts

* Update question-response-panel.component.ts

---------

Co-authored-by: Jason Qiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.Low Very little impact; unlikely to do in the near future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#12499] Flickering questions when loading session results blejkowski/teammates
10 participants
@jasonqiu212 @domlimm @OpherM @weiquu @Zxun2 @rajatmohan22 @blejkowski @HarshSingh21 @tushargupta123 @Sourav-Kumar-Panda