Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify minimum page height to factor in footer height #12265

Closed
zhaojj2209 opened this issue Mar 27, 2023 · 2 comments · Fixed by #12406
Closed

Modify minimum page height to factor in footer height #12265

zhaojj2209 opened this issue Mar 27, 2023 · 2 comments · Fixed by #12406
Labels
a-UIX User Interface, User eXperience, responsiveness c.Bug Bug/defect report good first issue Easy; restricted for first-time contributors p.Low Very little impact; unlikely to do in the near future

Comments

@zhaojj2209
Copy link
Contributor

Currently, the minimum page height only factors in the header height and does not factor in the footer height, causing some pages to scroll vertically even though the content fits within the browser window.

Screen.Recording.2023-03-27.at.13.10.44.mov

Suggestion: the footer height should be added in the calculation of the main content's minimum width. Take note that the height of the footer differs for desktop and mobile screen sizes, so that will have to be taken into account as well.
@zhaojj2209 zhaojj2209 added p.Low Very little impact; unlikely to do in the near future good first issue Easy; restricted for first-time contributors c.Bug Bug/defect report a-UIX User Interface, User eXperience, responsiveness labels Mar 27, 2023
@ryalin
Copy link
Contributor

ryalin commented Apr 17, 2023

Hello! I would like to work on this issue

@domlimm
Copy link
Contributor

domlimm commented Apr 17, 2023

@destroyer806 Feel free to submit a PR for this issue 👍🏻

@ryalin ryalin mentioned this issue Apr 22, 2023
Merged
weiquu added a commit that referenced this issue Apr 27, 2023
@ryalin @zhaojj2209 @weiquu
[#12265] Modify minimum page height to factor in footer height (#12406)
a4d335d 
* Edited css main-height variable to calculate footer position based on screen width

* Added another case if the screen width is below 314px (Which will probably never happen)

* Removed extra space and end of lines

* Update src/web/app/page.component.scss by removing the footer case for 313px width and below

Co-authored-by: Zhao Jingjing <[email protected]>

* Removed 590px or above case and below 313px case for screen width

---------

Co-authored-by: Ryan Lin <[email protected]>
Co-authored-by: Zhao Jingjing <[email protected]>
Co-authored-by: Ryan Lin <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness c.Bug Bug/defect report good first issue Easy; restricted for first-time contributors p.Low Very little impact; unlikely to do in the near future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#12265] Modify minimum page height to factor in footer height Sho-Shoo/teammates-C2
3 participants
@domlimm @zhaojj2209 @ryalin